TODOΒΆ

  • templates/javascript.js.j2:4 sends every page whose visible text contains β€œyour Pi-hole” to /admin/. With services.javascript enabled the Clients page (/admin/groups/clients), the Pi-hole diagnosis page (/admin/messages) and the Teleporter settings (/admin/settings/teleporter) therefore open the dashboard instead of their own content (measured on the compose stack with javascript on and sso off: the browser ends on /admin/ and shows the dashboard tiles; the templates of all three pages carry the phrase in their help texts). Cause: redirectIfAccessDenied matches a phrase of the 403 page that upstream also uses on regular pages. Options: match the 403 page by its own markup (h2.error-headline, body class page-error403) instead of by a phrase; return early when document.body.classList.contains("logged-in"); or drop the redirect, because the app answers / with its own 308 to /admin/ once the request host equals webserver.domain.